RE: [Intel-wired-lan] [PATCH net-next 0/7] net: Don't use %pK through printk

[Loktionov, Aleksandr]

> -----Original Message-----
> From: Intel-wired-lan <intel-wired-lan-bounces@xxxxxxxxxx> On Behalf Of
> Thomas Weißschuh
> Sent: Monday, April 14, 2025 10:26 AM
> To: Jeff Johnson <jjohnson@xxxxxxxxxx>; Loic Poulain
> <loic.poulain@xxxxxxxxxx>; Brian Norris <briannorris@xxxxxxxxxxxx>;
> Francesco Dolcini <francesco@xxxxxxxxxx>; Nguyen, Anthony L
> <anthony.l.nguyen@xxxxxxxxx>; Kitszel, Przemyslaw
> <przemyslaw.kitszel@xxxxxxxxx>; Andrew Lunn <andrew+netdev@xxxxxxx>;
> David S. Miller <davem@xxxxxxxxxxxxx>; Dumazet, Eric
> <edumazet@xxxxxxxxxx>; Jakub Kicinski <kuba@xxxxxxxxxx>; Paolo Abeni
> <pabeni@xxxxxxxxxx>; Saeed Mahameed <saeedm@xxxxxxxxxx>; Leon
> Romanovsky <leon@xxxxxxxxxx>; Tariq Toukan <tariqt@xxxxxxxxxx>
> Cc: ath10k@xxxxxxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx;
> ath11k@xxxxxxxxxxxxxxxxxxx; ath12k@xxxxxxxxxxxxxxxxxxx;
> wcn36xx@xxxxxxxxxxxxxxxxxxx; linux-wireless@xxxxxxxxxxxxxxx; intel-wired-
> lan@xxxxxxxxxxxxxxxx; netdev@xxxxxxxxxxxxxxx; linux-rdma@xxxxxxxxxxxxxxx;
> Thomas Weißschuh <thomas.weissschuh@xxxxxxxxxxxxx>
> Subject: [Intel-wired-lan] [PATCH net-next 0/7] net: Don't use %pK through
> printk
> 
> In the past %pK was preferable to %p as it would not leak raw pointer values
> into the kernel log.
> Since commit ad67b74d2469 ("printk: hash addresses printed with %p") the
> regular %p has been improved to avoid this issue.
> Furthermore, restricted pointers ("%pK") were never meant to be used
> through printk(). They can still unintentionally leak raw pointers or acquire
> sleeping looks in atomic contexts.
> 
> Switch to the regular pointer formatting which is safer and easier to reason
> about.
> There are still a few users of %pK left, but these use it through seq_file, for
> which its usage is safe.
> 
> Signed-off-by: Thomas Weißschuh <thomas.weissschuh@xxxxxxxxxxxxx>
> ---
> Thomas Weißschuh (7):
>       wifi: ath10k: Don't use %pK through printk
>       wifi: ath11k: Don't use %pK through printk
>       wifi: ath12k: Don't use %pK through printk
>       wifi: wcn36xx: Don't use %pK through printk
>       wifi: mwifiex: Don't use %pK through printk
>       ice: Don't use %pK through printk or tracepoints
>       net/mlx5: Don't use %pK through tracepoints
> 
>  drivers/net/ethernet/intel/ice/ice_main.c          |  2 +-
>  drivers/net/ethernet/intel/ice/ice_trace.h         | 10 +++++-----
>  .../mlx5/core/sf/dev/diag/dev_tracepoint.h         |  2 +-
>  drivers/net/wireless/ath/ath10k/ahb.c              |  2 +-
>  drivers/net/wireless/ath/ath10k/bmi.c              |  6 +++---
>  drivers/net/wireless/ath/ath10k/ce.c               |  4 ++--
>  drivers/net/wireless/ath/ath10k/core.c             |  4 ++--
>  drivers/net/wireless/ath/ath10k/htc.c              |  6 +++---
>  drivers/net/wireless/ath/ath10k/htt_rx.c           |  2 +-
>  drivers/net/wireless/ath/ath10k/mac.c              | 22 +++++++++++-----------
>  drivers/net/wireless/ath/ath10k/pci.c              |  2 +-
>  drivers/net/wireless/ath/ath10k/testmode.c         |  4 ++--
>  drivers/net/wireless/ath/ath10k/txrx.c             |  2 +-
>  drivers/net/wireless/ath/ath10k/usb.c              |  4 ++--
>  drivers/net/wireless/ath/ath10k/wmi.c              |  4 ++--
>  drivers/net/wireless/ath/ath11k/testmode.c         |  2 +-
>  drivers/net/wireless/ath/ath12k/testmode.c         |  4 ++--
>  drivers/net/wireless/ath/wcn36xx/testmode.c        |  2 +-
>  drivers/net/wireless/marvell/mwifiex/pcie.c        |  2 +-
>  19 files changed, 43 insertions(+), 43 deletions(-)
> ---
> base-commit: 8ffd015db85fea3e15a77027fda6c02ced4d2444
> change-id: 20250404-restricted-pointers-net-a8cddd03e5d1
> 
> Best regards,
> --
> Thomas Weißschuh <thomas.weissschuh@xxxxxxxxxxxxx>
Reviewed-by: Aleksandr Loktionov <aleksandr.loktionov@xxxxxxxxx>