Re: [PATCH v3] rust: workqueue: remove HasWork::OFFSET

[Tejun Heo]

On Fri, Apr 11, 2025 at 04:14:35PM +0200, Alice Ryhl wrote:
> On Fri, Apr 11, 2025 at 4:08 PM Tamir Duberstein <tamird@xxxxxxxxx> wrote:
> >
> > Implement `HasWork::work_container_of` in `impl_has_work!`, narrowing
> > the interface of `HasWork` and replacing pointer arithmetic with
> > `container_of!`. Remove the provided implementation of
> > `HasWork::get_work_offset` without replacement; an implementation is
> > already generated in `impl_has_work!`. Remove the `Self: Sized` bound on
> > `HasWork::work_container_of` which was apparently necessary to access
> > `OFFSET` as `OFFSET` no longer exists.
> >
> > A similar API change was discussed on the hrtimer series[1].
> >
> > Link: https://lore.kernel.org/all/20250224-hrtimer-v3-v6-12-rc2-v9-1-5bd3bf0ce6cc@xxxxxxxxxx/ [1]
> > Reviewed-by: Benno Lossin <benno.lossin@xxxxxxxxx>
> > Reviewed-by: Alice Ryhl <aliceryhl@xxxxxxxxxx>
> > Tested-by: Alice Ryhl <aliceryhl@xxxxxxxxxx>
> > Reviewed-by: Andreas Hindborg <a.hindborg@xxxxxxxxxx>
> > Signed-off-by: Tamir Duberstein <tamird@xxxxxxxxx>
> 
> Seems reasonable enough.
> Reviewed-by: Alice Ryhl <aliceryhl@xxxxxxxxxx>

Acked-by: Tejun Heo <tj@xxxxxxxxxx>

Please let me know how you want it routed.

Thanks.

-- 
tejun