RE: [PATCH v3] hv/hv_kvp_daemon: Enable debug logs for hv_kvp_daemon
From: Dexuan Cui
Date: Mon Apr 14 2025 - 16:57:24 EST
> From: Shradha Gupta <shradhagupta@xxxxxxxxxxxxxxxxxxx>
> Sent: Sunday, April 6, 2025 1:48 AM
> [...]
> @@ -1662,6 +1708,7 @@ void print_usage(char *argv[])
> fprintf(stderr, "Usage: %s [options]\n"
> "Options are:\n"
> " -n, --no-daemon stay in foreground, don't
> daemonize\n"
> + " -d, --debug-enabled Enable debug logs(syslog debug by
Maybe we can shorten --debug-enabled to --debug ? Just wanted to type
less characters :-)
IMO conventionally --debug already means "debugging is enabled".
> @@ -1681,12 +1728,13 @@ int main(int argc, char *argv[])
> static struct option long_options[] = {
> [...]
> + {"debug-enabled", no_argument, 0, 'd' },
Ditto.
Otherwise, LGTM.
Reviewed-by: Dexuan Cui <decui@xxxxxxxxxxxxx>