Re: [PATCH bpf-next v3 1/2] bpf, sockmap: Introduce tracing capability for sockmap

From: Cong Wang
Date: Mon Apr 14 2025 - 17:25:47 EST


On Tue, Apr 15, 2025 at 12:11:45AM +0800, Jiayuan Chen wrote:
> +#ifndef __TRACE_SOCKMAP_HELPER_ONCE_ONLY
> +#define __TRACE_SOCKMAP_HELPER_ONCE_ONLY
> +
> +enum sockmap_direct_type {
> + SOCKMAP_REDIR_NONE = 0,
> + SOCKMAP_REDIR_INGRESS,
> + SOCKMAP_REDIR_EGRESS,
> +};

I am curious why you need to define them here since you already pass
'ingress' as a parameter? Is it possible to reuse the BPF_F_INGRESS bit?

Thanks!