Re: [PATCH v3 2/2] writeback: Fix false warning in inode_to_wb()
From: Andreas Gruenbacher
Date: Mon Apr 14 2025 - 19:23:38 EST
On Mon, Apr 14, 2025 at 11:51 PM Andrew Morton
<akpm@xxxxxxxxxxxxxxxxxxxx> wrote:
> On Sat, 12 Apr 2025 18:39:12 +0200 Andreas Gruenbacher <agruenba@xxxxxxxxxx> wrote:
>
> > inode_to_wb() is used also for filesystems that don't support cgroup
> > writeback. For these filesystems inode->i_wb is stable during the
> > lifetime of the inode (it points to bdi->wb) and there's no need to hold
> > locks protecting the inode->i_wb dereference. Improve the warning in
> > inode_to_wb() to not trigger for these filesystems.
> >
> > Signed-off-by: Jan Kara <jack@xxxxxxx>
> > Reviewed-by: Andreas Gruenbacher <agruenba@xxxxxxxxxx>
>
> Yoo were on the patch delivery path so there should be a
> signed-off-by:Andreas somewhere. I made that change to the mm.git copy
> of this patch.
I guess that's fine as long as Jan is credited as the author.
Thanks,
Andreas