Re: [PATCH] dt-bindings: PCI: Convert marvell,armada8k-pcie to schema
From: Rob Herring
Date: Mon Apr 14 2025 - 20:53:24 EST
On Mon, Apr 14, 2025 at 5:29 PM Rob Herring (Arm) <robh@xxxxxxxxxx> wrote:
>
>
> On Mon, 14 Apr 2025 16:41:33 -0500, Rob Herring (Arm) wrote:
> > Convert the marvell,armada8k-pcie binding to DT schema. The binding
> > uses different names for reg, clocks, and phys which have to be added
> > to the common Synopsys DWC binding.
> >
> > The "marvell,reset-gpio" property was not documented. Mark it deprecated
> > as the "reset-gpios" property can be used instead. The "msi-parent"
> > property was also not documented.
> >
> > Signed-off-by: Rob Herring (Arm) <robh@xxxxxxxxxx>
> > ---
> > .../bindings/pci/marvell,armada8k-pcie.yaml | 100 ++++++++++++++++++
> > .../devicetree/bindings/pci/pci-armada8k.txt | 48 ---------
> > .../bindings/pci/snps,dw-pcie-common.yaml | 3 +-
> > .../devicetree/bindings/pci/snps,dw-pcie.yaml | 4 +-
> > MAINTAINERS | 2 +-
> > 5 files changed, 106 insertions(+), 51 deletions(-)
> > create mode 100644 Documentation/devicetree/bindings/pci/marvell,armada8k-pcie.yaml
> > delete mode 100644 Documentation/devicetree/bindings/pci/pci-armada8k.txt
> >
>
> My bot found errors running 'make dt_binding_check' on your patch:
>
> yamllint warnings/errors:
>
> dtschema/dtc warnings/errors:
> /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/pci/marvell,armada8k-pcie.example.dtb: pcie@f2600000 (marvell,armada8k-pcie): interrupts: [[0], [32], [4]] is too long
> from schema $id: http://devicetree.org/schemas/pci/marvell,armada8k-pcie.yaml#
This is a bug in dtschema which I've now fixed.
Rob