Re: [tip: core/urgent] compiler.h: Avoid the usage of __typeof_unqual__() when __GENKSYMS__ is defined

From: Andrew Morton
Date: Mon Apr 14 2025 - 21:21:05 EST


On Sun, 13 Apr 2025 21:20:00 +0200 Ingo Molnar <mingo@xxxxxxxxxx> wrote:

> > > > If this commit is removed, [...]
> > >
> > > I did not remove commit ac053946f5c4, it's already upstream. Nor
> > > did I advocate for it to be reverted - I'd like it to be fixed. So
> > > you are barking up the wrong tree.
> >
> > If the intention is to pass my proposed workaround via Andrew's tree,
> > then I'm happy to bark up the wrong tree, but from the referred
> > message trail, I didn't get the clear decision about the patch, and
> > neither am sure which patch "brown paper bag bug" refers to.
>
> It's up to akpm (he merged your original patch that regressed), but I
> think scripts/genksyms/ should be fixed instead of worked around -
> which is why I zapped the workaround.

I'm OK with the original workaround - super simple and fixes the issue.
I don't know if Borislav intends to upstream this, so I'll grab a copy
also.

Nobody has commented on Uros's more recent alteration to genksyms
(https://lkml.kernel.org/r/CAFULd4aLMF_2AbUAvpYw+o1qo6U-Ya_+Ewy-wW17g-r-MBF9_g@xxxxxxxxxxxxxx)?

Uros, please persist with that approach and hopefully we'll have a
patch which removes the temporary workaround.