Re: [PATCH net-next v10 1/1] hinic3: module initialization and tx/rx logic

[Jakub Kicinski]

On Thu, 10 Apr 2025 15:15:51 +0300 Gur Stavi wrote:
> +	err = dma_set_mask_and_coherent(&pdev->dev, DMA_BIT_MASK(64));
> +	if (err) {
> +		dev_warn(&pdev->dev, "Couldn't set 64-bit DMA mask\n");
> +		/* try 32 bit DMA mask if 64 bit fails */
> +		err = dma_set_mask_and_coherent(&pdev->dev, DMA_BIT_MASK(32));
> +		if (err) {
> +			dev_err(&pdev->dev, "Failed to set DMA mask\n");
> +			goto err_release_regions;
> +		}

Please take a look at commit 004464835bfc ("hinic: Remove useless
DMA-32 fallback configuration"). This construct was removed in your
other driver now you're bringing it back.