Re: [PATCH v5 19/21] riscv: dts: thead: Introduce power domain nodes with aon firmware

From: Drew Fustini
Date: Mon Apr 14 2025 - 22:04:41 EST


On Wed, Feb 19, 2025 at 03:02:37PM +0100, Michal Wilczynski wrote:
> The DRM Imagination GPU requires a power-domain driver. In the T-HEAD
> TH1520 SoC implements power management capabilities through the E902
> core, which can be communicated with through the mailbox, using firmware
> protocol.
>
> Add AON node, which servers as a power-domain controller.
>
> Signed-off-by: Michal Wilczynski <m.wilczynski@xxxxxxxxxxx>
> ---
> arch/riscv/boot/dts/thead/th1520.dtsi | 8 ++++++++
> 1 file changed, 8 insertions(+)
>
> diff --git a/arch/riscv/boot/dts/thead/th1520.dtsi b/arch/riscv/boot/dts/thead/th1520.dtsi
> index 197df1f32b25..474f31576a1b 100644
> --- a/arch/riscv/boot/dts/thead/th1520.dtsi
> +++ b/arch/riscv/boot/dts/thead/th1520.dtsi
> @@ -6,6 +6,7 @@
>
> #include <dt-bindings/interrupt-controller/irq.h>
> #include <dt-bindings/clock/thead,th1520-clk-ap.h>
> +#include <dt-bindings/power/thead,th1520-power.h>
>
> / {
> compatible = "thead,th1520";
> @@ -229,6 +230,13 @@ stmmac_axi_config: stmmac-axi-config {
> snps,blen = <0 0 64 32 0 0 0>;
> };
>
> + aon: aon {
> + compatible = "thead,th1520-aon";
> + mboxes = <&mbox_910t 1>;
> + mbox-names = "aon";
> + #power-domain-cells = <1>;
> + };
> +
> soc {
> compatible = "simple-bus";
> interrupt-parent = <&plic>;
> --
> 2.34.1
>

Reviewed-by: Drew Fustini <drew@xxxxxxxx>

I tested this on top of 6.15-rc1 and found no issues.

-Drew