Re: [PATCH] soc: hisilicon: kunpeng_hccs: Simplify PCC shared memory region handling
From: Sudeep Holla
Date: Tue Apr 15 2025 - 04:35:41 EST
On Tue, Apr 15, 2025 at 02:26:40PM +0800, lihuisong (C) wrote:
> +Wei who is Hisilicon SoC maintainer.
>
> 在 2025/4/11 19:25, Sudeep Holla 写道:
> > The PCC driver now handles mapping and unmapping of shared memory
> > areas as part of pcc_mbox_{request,free}_channel(). Without these before,
> > this Kunpeng HCCS driver did handling of those mappings like several
> > other PCC mailbox client drivers.
> >
> > There were redundant operations, leading to unnecessary code. Maintaining
> > the consistency across these driver was harder due to scattered handling
> > of shmem.
> >
> > Just use the mapped shmem and remove all redundant operations from this
> > driver.
> >
> > Cc: Huisong Li <lihuisong@xxxxxxxxxx>
> > Signed-off-by: Sudeep Holla <sudeep.holla@xxxxxxx>
> Reviewed-by: Huisong Li <lihuisong@xxxxxxxxxx>
Thanks and sorry for dropping it assuming you will pick it up.
The maintainers file just list you.
Wei,
Let me know if you want me to repost or if you can pick it from [1]
--
Regards,
Sudeep
[1] https://lore.kernel.org/all/20250411112539.1149863-1-sudeep.holla@xxxxxxx/