Re: [PATCH v3 02/54] docs/dyndbg: update examples \012 to \n

[Louis Chauvet]

Le 02/04/2025 à 19:41, Jim Cromie a écrit :
> commit 47ea6f99d06e ("dyndbg: use ESCAPE_SPACE for cat control")
> changed the control-file to display format strings with "\n" rather
> than "\012".  Update the docs to match the new reality.

Hi,

I don't know what is the process for dyndbg and how much review you 
need, but what are your thoughts on applying 02..09 as soon it is 
possible to reduce the size of the series?

Thanks,
Louis Chauvet

> Signed-off-by: Jim Cromie <jim.cromie@xxxxxxxxx>
> Reviewed-by: Louis Chauvet <louis.chauvet@xxxxxxxxxxx>
> Tested-by: Louis Chauvet<louis.chauvet@xxxxxxxxxxx>
> ---
> -v2 fix missed \012's
> ---
>   .../admin-guide/dynamic-debug-howto.rst       | 20 +++++++++----------
>   1 file changed, 10 insertions(+), 10 deletions(-)
>
> diff --git a/Documentation/admin-guide/dynamic-debug-howto.rst b/Documentation/admin-guide/dynamic-debug-howto.rst
> index 7c036590cd07..4ac18c0a1d95 100644
> --- a/Documentation/admin-guide/dynamic-debug-howto.rst
> +++ b/Documentation/admin-guide/dynamic-debug-howto.rst
> @@ -38,12 +38,12 @@ You can view the currently configured behaviour in the *prdbg* catalog::
>   
>     :#> head -n7 /proc/dynamic_debug/control
>     # filename:lineno [module]function flags format
> -  init/main.c:1179 [main]initcall_blacklist =_ "blacklisting initcall %s\012
> -  init/main.c:1218 [main]initcall_blacklisted =_ "initcall %s blacklisted\012"
> -  init/main.c:1424 [main]run_init_process =_ "  with arguments:\012"
> -  init/main.c:1426 [main]run_init_process =_ "    %s\012"
> -  init/main.c:1427 [main]run_init_process =_ "  with environment:\012"
> -  init/main.c:1429 [main]run_init_process =_ "    %s\012"
> +  init/main.c:1179 [main]initcall_blacklist =_ "blacklisting initcall %s\n"
> +  init/main.c:1218 [main]initcall_blacklisted =_ "initcall %s blacklisted\n"
> +  init/main.c:1424 [main]run_init_process =_ "  with arguments:\n"
> +  init/main.c:1426 [main]run_init_process =_ "    %s\n"
> +  init/main.c:1427 [main]run_init_process =_ "  with environment:\n"
> +  init/main.c:1429 [main]run_init_process =_ "    %s\n"
>   
>   The 3rd space-delimited column shows the current flags, preceded by
>   a ``=`` for easy use with grep/cut. ``=p`` shows enabled callsites.
> @@ -59,10 +59,10 @@ query/commands to the control file.  Example::
>   
>     :#> ddcmd '-p; module main func run* +p'
>     :#> grep =p /proc/dynamic_debug/control
> -  init/main.c:1424 [main]run_init_process =p "  with arguments:\012"
> -  init/main.c:1426 [main]run_init_process =p "    %s\012"
> -  init/main.c:1427 [main]run_init_process =p "  with environment:\012"
> -  init/main.c:1429 [main]run_init_process =p "    %s\012"
> +  init/main.c:1424 [main]run_init_process =p "  with arguments:\n"
> +  init/main.c:1426 [main]run_init_process =p "    %s\n"
> +  init/main.c:1427 [main]run_init_process =p "  with environment:\n"
> +  init/main.c:1429 [main]run_init_process =p "    %s\n"
>   
>   Error messages go to console/syslog::
>   

--
Louis Chauvet, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com