Re: [PATCH v3 53/54] drm: restore CONFIG_DRM_USE_DYNAMIC_DEBUG un-BROKEN

[Louis Chauvet]

Le 02/04/2025 à 19:41, Jim Cromie a écrit :
> Time for some thorough CI.
>
> Also, the previous 18 patches could perhaps be replaced by a single
> invocation of DYNDBG_CLASSMAP_USE, from a C-file linked into all drm
> drivers & helpers.  I didn't find such a file, nor a drm-client
> linkage item in the Makefile.
>
> Signed-off-by: Jim Cromie <jim.cromie@xxxxxxxxx>

Reviewed-by: Louis Chauvet <louis.chauvet@xxxxxxxxxxx>

Since [1] this patch does not apply on drm-misc-next, but the fix is 
easy, just move the change to the correct file.

[1]: 
https://patchwork.freedesktop.org/patch/msgid/20250324092633.49746-2-tvrtko.ursulin@xxxxxxxxxx

> ---
>   drivers/gpu/drm/Kconfig | 3 +--
>   1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/Kconfig b/drivers/gpu/drm/Kconfig
> index fbef3f471bd0..c7d6adbe17eb 100644
> --- a/drivers/gpu/drm/Kconfig
> +++ b/drivers/gpu/drm/Kconfig
> @@ -53,8 +53,7 @@ config DRM_DEBUG_MM
>   
>   config DRM_USE_DYNAMIC_DEBUG
>   	bool "use dynamic debug to implement drm.debug"
> -	default n
> -	depends on BROKEN
> +	default y
>   	depends on DRM
>   	depends on DYNAMIC_DEBUG || DYNAMIC_DEBUG_CORE
>   	depends on JUMP_LABEL

--
Louis Chauvet, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com