Re: [PATCH] hfs{plus}: add deprecation warning

[Jan Kara]

On Tue 15-04-25 09:51:37, Christian Brauner wrote:
> Both the hfs and hfsplus filesystem have been orphaned since at least
> 2014, i.e., over 10 years. It's time to remove them from the kernel as
> they're exhibiting more and more issues and no one is stepping up to
> fixing them.
> 
> Signed-off-by: Christian Brauner <brauner@xxxxxxxxxx>

Looks good. And I agree hopefully it sparks interest in the maintainership
because this is not completely useless filesystem:

Acked-by: Jan Kara <jack@xxxxxxx>

								Honza

> ---
>  fs/hfs/super.c     | 2 ++
>  fs/hfsplus/super.c | 2 ++
>  2 files changed, 4 insertions(+)
> 
> diff --git a/fs/hfs/super.c b/fs/hfs/super.c
> index fe09c2093a93..4413cd8feb9e 100644
> --- a/fs/hfs/super.c
> +++ b/fs/hfs/super.c
> @@ -404,6 +404,8 @@ static int hfs_init_fs_context(struct fs_context *fc)
>  {
>  	struct hfs_sb_info *hsb;
>  
> +	pr_warn("The hfs filesystem is deprecated and scheduled to be removed from the kernel in 2025\n");
> +
>  	hsb = kzalloc(sizeof(struct hfs_sb_info), GFP_KERNEL);
>  	if (!hsb)
>  		return -ENOMEM;
> diff --git a/fs/hfsplus/super.c b/fs/hfsplus/super.c
> index 948b8aaee33e..58cff4b2a3b4 100644
> --- a/fs/hfsplus/super.c
> +++ b/fs/hfsplus/super.c
> @@ -656,6 +656,8 @@ static int hfsplus_init_fs_context(struct fs_context *fc)
>  {
>  	struct hfsplus_sb_info *sbi;
>  
> +	pr_warn("The hfsplus filesystem is deprecated and scheduled to be removed from the kernel in 2025\n");
> +
>  	sbi = kzalloc(sizeof(struct hfsplus_sb_info), GFP_KERNEL);
>  	if (!sbi)
>  		return -ENOMEM;
> -- 
> 2.47.2
> 
-- 
Jan Kara <jack@xxxxxxxx>
SUSE Labs, CR