[net-next PATCH] net: phy: mediatek: init val in .phy_led_polarity_set for AN7581
From: Christian Marangi
Date: Tue Apr 15 2025 - 06:57:29 EST
Fix smatch warning for uninitialised val in .phy_led_polarity_set for
AN7581 driver.
Correctly init to 0 to set polarity high by default.
Reported-by: Simon Horman <horms@xxxxxxxxxx>
Fixes: 6a325aed130b ("net: phy: mediatek: add Airoha PHY ID to SoC driver")
Signed-off-by: Christian Marangi <ansuelsmth@xxxxxxxxx>
---
drivers/net/phy/mediatek/mtk-ge-soc.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/net/phy/mediatek/mtk-ge-soc.c b/drivers/net/phy/mediatek/mtk-ge-soc.c
index fd0e447ffce7..cd09684780a4 100644
--- a/drivers/net/phy/mediatek/mtk-ge-soc.c
+++ b/drivers/net/phy/mediatek/mtk-ge-soc.c
@@ -1432,8 +1432,8 @@ static int an7581_phy_probe(struct phy_device *phydev)
static int an7581_phy_led_polarity_set(struct phy_device *phydev, int index,
unsigned long modes)
{
+ u16 val = 0;
u32 mode;
- u16 val;
if (index >= MTK_PHY_MAX_LEDS)
return -EINVAL;
@@ -1444,7 +1444,6 @@ static int an7581_phy_led_polarity_set(struct phy_device *phydev, int index,
val = MTK_PHY_LED_ON_POLARITY;
break;
case PHY_LED_ACTIVE_HIGH:
- val = 0;
break;
default:
return -EINVAL;
--
2.48.1