Re: [PATCH net-next v2] net: ncsi: Fix GCPS 64-bit member variables

[Paul Fertser]

Hello,

On Wed, Apr 09, 2025 at 06:23:08PM -0700, kalavakunta.hari.prasad@xxxxxxxxx wrote:
> From: Hari Kalavakunta <kalavakunta.hari.prasad@xxxxxxxxx>
> 
> Correct Get Controller Packet Statistics (GCPS) 64-bit wide member
> variables, as per DSP0222 v1.0.0 and forward specs. The Driver currently
> collects these stats, but they are yet to be exposed to the user.
> Therefore, no user impact.
> 
> Statistics fixes:
> Total Bytes Received (byte range 28..35)
> Total Bytes Transmitted (byte range 36..43)
> Total Unicast Packets Received (byte range 44..51)
> Total Multicast Packets Received (byte range 52..59)
> Total Broadcast Packets Received (byte range 60..67)
> Total Unicast Packets Transmitted (byte range 68..75)
> Total Multicast Packets Transmitted (byte range 76..83)
> Total Broadcast Packets Transmitted (byte range 84..91)
> Valid Bytes Received (byte range 204..11)
> 
> v2:
> - __be64 for all 64 bit GCPS counters
> 
> Signed-off-by: Hari Kalavakunta <kalavakunta.hari.prasad@xxxxxxxxx>

This version looks correct to me (other than the changelog being
before ---) so

Reviewed-by: Paul Fertser <fercerpav@xxxxxxxxx>