Re: [PATCH v2] drm/amd/pm/powerplay/smumgr/fiji_smumgr: Add error check in fiji_populate_smc_boot_level()

From: Markus Elfring
Date: Tue Apr 15 2025 - 07:55:47 EST


> The return value of fiji_populate_smc_boot_level() is needs to be checked.

should?


> An error handling is also needed to phm_find_boot_level() to reset the
> boot level when the function fails. A proper implementation can be found
> in tonga_populate_smc_boot_level().

Can you propose in a nicer way to complete the error handling?

Regards,
Markus