Re: [PATCH] dmaengine: ptdma: Remove unused pointer dma_cmd_cache

[Eder Zulian]

Hello Nathan,

On Mon, Apr 14, 2025 at 05:58:40PM -0500, Nathan Lynch wrote:
> Eder Zulian <ezulian@xxxxxxxxxx> writes:
> > The pointer 'struct kmem_cache *dma_cmd_cache' was introduced in commit
> > b0b4a6b10577 ("dmaengine: ptdma: register PTDMA controller as a DMA
> > resource") but it was never used.
> >
> > Signed-off-by: Eder Zulian <ezulian@xxxxxxxxxx>
> > ---
> >  drivers/dma/amd/ptdma/ptdma-dmaengine.c | 3 ---
> >  drivers/dma/amd/ptdma/ptdma.h           | 1 -
> >  2 files changed, 4 deletions(-)
> >
> > diff --git a/drivers/dma/amd/ptdma/ptdma-dmaengine.c b/drivers/dma/amd/ptdma/ptdma-dmaengine.c
> > index 715ac3ae067b..3f7f6da05142 100644
> > --- a/drivers/dma/amd/ptdma/ptdma-dmaengine.c
> > +++ b/drivers/dma/amd/ptdma/ptdma-dmaengine.c
> > @@ -656,8 +656,6 @@ int pt_dmaengine_register(struct pt_device *pt)
> >  	kmem_cache_destroy(pt->dma_desc_cache);
> >  
> >  err_cache:
> > -	kmem_cache_destroy(pt->dma_cmd_cache);
> > -
> 
> I think you could remove the 'err_cache' label and convert the users of it
> to return -ENOMEM directly, since there aren't any unmanaged allocations
> to unwind:
> 
> 	desc_cache_name = devm_kasprintf(pt->dev, GFP_KERNEL,
> 					 "%s-dmaengine-desc-cache",
> 					 dev_name(pt->dev));
> 	if (!desc_cache_name) {
> 		ret = -ENOMEM;
> 		goto err_cache;
> 	}
> 
> 	pt->dma_desc_cache = kmem_cache_create(desc_cache_name,
> 					       sizeof(struct pt_dma_desc), 0,
> 					       SLAB_HWCACHE_ALIGN, NULL);
> 	if (!pt->dma_desc_cache) {
> 		ret = -ENOMEM;
> 		goto err_cache;
> 	}
> 
> Otherwise LGTM.
> 
Thank you for your review and suggestion. Please find a link to the v2.

https://lore.kernel.org/dmaengine/20250415121312.870124-1-ezulian@xxxxxxxxxx/

Eder