Re: [PATCH v3 10/17] drm/bridge: cdns-dsi: Update htotal in cdns_dsi_mode2cfg()

From: Aradhya Bhatia
Date: Tue Apr 15 2025 - 09:23:50 EST




On 14/04/25 16:41, Tomi Valkeinen wrote:
> cdns_dsi_mode2cfg() calculates the dsi timings, but for some reason
> doesn't set the htotal based on those timings. It is set only later, in
> cdns_dsi_adjust_phy_config().
>
> As cdns_dsi_mode2cfg() is the logical place to calculate it, let's move
> it there. Especially as the following patch will remove
> cdns_dsi_adjust_phy_config().
>
> Signed-off-by: Tomi Valkeinen <tomi.valkeinen@xxxxxxxxxxxxxxxx>
> ---
> drivers/gpu/drm/bridge/cadence/cdns-dsi-core.c | 14 ++++++++------
> 1 file changed, 8 insertions(+), 6 deletions(-)
>

Reviewed-by: Aradhya Bhatia <aradhya.bhatia@xxxxxxxxx>

--
Regards
Aradhya