Re: [1/1] i2c: designware: Ensure runtime suspend is invoked during rapid slave unregistration and registration

[Jarkko Nikula]

Hi

On 4/12/25 5:33 AM, ende.tan@xxxxxxxxxxxxxxxx wrote:
> From: Tan En De <ende.tan@xxxxxxxxxxxxxxxx>
>
> Replaced pm_runtime_put() with pm_runtime_put_sync_suspend() to ensure
> the runtime suspend is invoked immediately when unregistering a slave.
> This prevents a race condition where suspend was skipped when
> unregistering and registering slave in quick succession.
>
> Signed-off-by: Tan En De <ende.tan@xxxxxxxxxxxxxxxx>
> ---
>   drivers/i2c/busses/i2c-designware-slave.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/i2c/busses/i2c-designware-slave.c b/drivers/i2c/busses/i2c-designware-slave.c
> index 5cd4a5f7a472..b936a240db0a 100644
> --- a/drivers/i2c/busses/i2c-designware-slave.c
> +++ b/drivers/i2c/busses/i2c-designware-slave.c
> @@ -96,7 +96,7 @@ static int i2c_dw_unreg_slave(struct i2c_client *slave)
>   	i2c_dw_disable(dev);
>   	synchronize_irq(dev->irq);
>   	dev->slave = NULL;
> -	pm_runtime_put(dev->dev);
> +	pm_runtime_put_sync_suspend(dev->dev);
>   
>   	return 0;
>   }

What kind of issue you are seeing?

I tried to test with no delay and 1 second delays between registering 
and unregistering. Power state was changing between D0 and D3 if there 
was delay between unregister and register but I could not see any issue.