Re: [PATCH v3 1/1] cxl/feature: Update out_len in set feature failure case

[Jonathan Cameron]

On Thu, 10 Apr 2025 10:45:21 +0800
Li Ming <ming.li@xxxxxxxxxxxx> wrote:

> CXL subsystem supports userspace to configure features via fwctl
> interface, it will configure features by using Set Feature command.
> Whatever Set Feature succeeds or fails, CXL driver always needs to
> return a structure fwctl_rpc_cxl_out to caller, and returned size is
> updated in a out_len parameter. The out_len should be updated not only
> when the set feature succeeds, but also when the set feature fails.
> 
> Fixes: eb5dfcb9e36d ("cxl: Add support to handle user feature commands for set feature")
> Signed-off-by: Li Ming <ming.li@xxxxxxxxxxxx>
> Reviewed-by: Dave Jiang <dave.jiang@xxxxxxxxx>
> Reviewed-by: Ira Weiny <ira.weiny@xxxxxxxxx>
Seems reasonable and well explained.
Reviewed-by: Jonathan Cameron <Jonathan.Cameron@xxxxxxxxxx>