Re: [syzbot] [udf?] possible deadlock in udf_free_blocks

[syzbot]

Hello,

syzbot has tested the proposed patch but the reproducer is still triggering an issue:
possible deadlock in udf_free_blocks

============================================
WARNING: possible recursive locking detected
6.15.0-rc2-syzkaller-00037-g834a4a689699 #0 Not tainted
--------------------------------------------
syz.0.53/6250 is trying to acquire lock:
ffff88802863ed28 (&sbi->s_alloc_mutex){+.+.}-{4:4}, at: udf_table_free_blocks fs/udf/balloc.c:375 [inline]
ffff88802863ed28 (&sbi->s_alloc_mutex){+.+.}-{4:4}, at: udf_free_blocks+0xa28/0x22b0 fs/udf/balloc.c:677

but task is already holding lock:
ffff88802863ed28 (&sbi->s_alloc_mutex){+.+.}-{4:4}, at: udf_table_new_block fs/udf/balloc.c:581 [inline]
ffff88802863ed28 (&sbi->s_alloc_mutex){+.+.}-{4:4}, at: udf_new_block+0xf6f/0x21c0 fs/udf/balloc.c:725

other info that might help us debug this:
 Possible unsafe locking scenario:

       CPU0
       ----
  lock(&sbi->s_alloc_mutex);
  lock(&sbi->s_alloc_mutex);

 *** DEADLOCK ***

 May be due to missing lock nesting notation

4 locks held by syz.0.53/6250:
 #0: ffff88807fe26420 (sb_writers#12){.+.+}-{0:0}, at: direct_splice_actor+0x49/0x220 fs/splice.c:1157
 #1: ffff88806319fbc0 (&sb->s_type->i_mutex_key#21){+.+.}-{4:4}, at: inode_lock include/linux/fs.h:867 [inline]
 #1: ffff88806319fbc0 (&sb->s_type->i_mutex_key#21){+.+.}-{4:4}, at: udf_file_write_iter+0x6d/0x6c0 fs/udf/file.c:95
 #2: ffff88806319f9f0 (&ei->i_data_sem#2){++++}-{4:4}, at: udf_map_block+0x3b9/0x53f0 fs/udf/inode.c:439
 #3: ffff88802863ed28 (&sbi->s_alloc_mutex){+.+.}-{4:4}, at: udf_table_new_block fs/udf/balloc.c:581 [inline]
 #3: ffff88802863ed28 (&sbi->s_alloc_mutex){+.+.}-{4:4}, at: udf_new_block+0xf6f/0x21c0 fs/udf/balloc.c:725

stack backtrace:
CPU: 1 UID: 0 PID: 6250 Comm: syz.0.53 Not tainted 6.15.0-rc2-syzkaller-00037-g834a4a689699 #0 PREEMPT(full) 
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 02/12/2025
Call Trace:
 <TASK>
 __dump_stack lib/dump_stack.c:94 [inline]
 dump_stack_lvl+0x241/0x360 lib/dump_stack.c:120
 print_deadlock_bug+0x2be/0x2d0 kernel/locking/lockdep.c:3042
 check_deadlock kernel/locking/lockdep.c:3094 [inline]
 validate_chain+0x928/0x24e0 kernel/locking/lockdep.c:3896
 __lock_acquire+0xad5/0xd80 kernel/locking/lockdep.c:5235
 lock_acquire+0x116/0x2f0 kernel/locking/lockdep.c:5866
 __mutex_lock_common kernel/locking/mutex.c:601 [inline]
 __mutex_lock+0x1d1/0x1150 kernel/locking/mutex.c:746
 udf_table_free_blocks fs/udf/balloc.c:375 [inline]
 udf_free_blocks+0xa28/0x22b0 fs/udf/balloc.c:677
 udf_delete_aext+0x70c/0xed0 fs/udf/inode.c:2373
 udf_table_new_block fs/udf/balloc.c:645 [inline]
 udf_new_block+0x18a6/0x21c0 fs/udf/balloc.c:725
 inode_getblk fs/udf/inode.c:895 [inline]
 udf_map_block+0x1ce5/0x53f0 fs/udf/inode.c:447
 __udf_get_block+0x128/0x410 fs/udf/inode.c:461
 __block_write_begin_int+0x693/0x1930 fs/buffer.c:2116
 block_write_begin+0x8f/0x120 fs/buffer.c:2227
 udf_write_begin+0xfc/0x250 fs/udf/inode.c:256
 generic_perform_write+0x32b/0xa10 mm/filemap.c:4102
 udf_file_write_iter+0x2e7/0x6c0 fs/udf/file.c:111
 iter_file_splice_write+0xbe1/0x1530 fs/splice.c:738
 do_splice_from fs/splice.c:935 [inline]
 direct_splice_actor+0x11d/0x220 fs/splice.c:1158
 splice_direct_to_actor+0x597/0xc90 fs/splice.c:1102
 do_splice_direct_actor fs/splice.c:1201 [inline]
 do_splice_direct+0x281/0x3d0 fs/splice.c:1227
 do_sendfile+0x582/0x8c0 fs/read_write.c:1368
 __do_sys_sendfile64 fs/read_write.c:1429 [inline]
 __se_sys_sendfile64+0x17e/0x1e0 fs/read_write.c:1415
 do_syscall_x64 arch/x86/entry/syscall_64.c:63 [inline]
 do_syscall_64+0xf3/0x230 arch/x86/entry/syscall_64.c:94
 entry_SYSCALL_64_after_hwframe+0x77/0x7f
RIP: 0033:0x7fbb55b85d29
Code: ff ff c3 66 2e 0f 1f 84 00 00 00 00 00 0f 1f 40 00 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 a8 ff ff ff f7 d8 64 89 01 48
RSP: 002b:00007fbb56933038 EFLAGS: 00000246 ORIG_RAX: 0000000000000028
RAX: ffffffffffffffda RBX: 00007fbb55d76080 RCX: 00007fbb55b85d29
RDX: 0000000000000000 RSI: 0000000000000006 RDI: 0000000000000005
RBP: 00007fbb55c01aa8 R08: 0000000000000000 R09: 0000000000000000
R10: 0001000000201005 R11: 0000000000000246 R12: 0000000000000000
R13: 0000000000000000 R14: 00007fbb55d76080 R15: 00007ffea135d3b8
 </TASK>


Tested on:

commit:         834a4a68 Merge tag 'for-linus' of git://git.kernel.org..
git tree:       upstream
console output: https://syzkaller.appspot.com/x/log.txt?x=15bd1a3f980000
kernel config:  https://syzkaller.appspot.com/x/.config?x=5dd916f7ca732ed
dashboard link: https://syzkaller.appspot.com/bug?extid=d472c32c5dd4cd2fb5c5
compiler:       Debian clang version 15.0.6, GNU ld (GNU Binutils for Debian) 2.40

Note: no patches were applied.