Re: [PATCH v1 0/2] add support for MCP998X

[Jonathan Cameron]

On Tue, 15 Apr 2025 16:26:21 +0300
<victor.duicu@xxxxxxxxxxxxx> wrote:

> From: Victor Duicu <victor.duicu@xxxxxxxxxxxxx>
> 
> Add support for Microchip MCP998X/33 and MCP998XD/33D
> Multichannel Automotive Temperature Monitor Family.
> 
> The chip is capable of monitoring temperatures on four
> external channels and one internal.
Hi Victor,

This gets the standard question for a temperature sensor...
Why IIO and not hwmon?  Good to have that info in the cover letter or
patch description.

I'd normally moan about the wild cards even though they are only
in patch titles, but meh, the datasheet uses the wild card
so we are probably safe for a while at least!

Jonathan


> 
> Victor Duicu (2):
>   dt-bindings: iio: temperature: add support for MCP998X
>   iio: temperature: add support for MCP998X
> 
>  .../testing/sysfs-bus-iio-temperature-mcp9982 |  17 +
>  .../iio/temperature/microchip,mcp9982.yaml    | 182 ++++
>  MAINTAINERS                                   |   7 +
>  drivers/iio/temperature/Kconfig               |  10 +
>  drivers/iio/temperature/Makefile              |   1 +
>  drivers/iio/temperature/mcp9982.c             | 794 ++++++++++++++++++
>  6 files changed, 1011 insertions(+)
>  create mode 100644 Documentation/ABI/testing/sysfs-bus-iio-temperature-mcp9982
>  create mode 100644 Documentation/devicetree/bindings/iio/temperature/microchip,mcp9982.yaml
>  create mode 100644 drivers/iio/temperature/mcp9982.c
> 
> 
> base-commit: 31c52fe3b2efeebfc72cc5336653baaa9889b41e