Re: [PATCH iwl-next 14/14] ixd: add devlink support

[Tony Nguyen]

On 4/8/2025 5:48 AM, Larysa Zaremba wrote:
> From: Amritha Nambiar <amritha.nambiar@xxxxxxxxx>
>
> Enable initial support for the devlink interface with the ixd
> driver. The ixd hardware is a single function PCIe device. So, the
> PCIe adapter gets its own devlink instance to manage device-wide
> resources or configuration.
>
> $ devlink dev show
> pci/0000:83:00.6
>
> $ devlink dev info pci/0000:83:00.6
> pci/0000:83:00.6:
>    driver ixd
>    serial_number 00-a0-c9-ff-ff-23-45-67
>    versions:
>        fixed:
>          device.type MEV
>        running:
>          cp 0.0
>          virtchnl 2.0
>
> Signed-off-by: Amritha Nambiar <amritha.nambiar@xxxxxxxxx>
> Reviewed-by: Michal Swiatkowski <michal.swiatkowski@xxxxxxxxxxxxxxx>
> Reviewed-by: Maciej Fijalkowski <maciej.fijalkowski@xxxxxxxxx>
> Reviewed-by: Przemek Kitszel <przemyslaw.kitszel@xxxxxxxxx>
> Signed-off-by: Larysa Zaremba <larysa.zaremba@xxxxxxxxx>
> ---
>   Documentation/networking/devlink/ixd.rst     |  35 +++++++
>   drivers/net/ethernet/intel/ixd/Kconfig       |   1 +
>   drivers/net/ethernet/intel/ixd/Makefile      |   1 +
>   drivers/net/ethernet/intel/ixd/ixd_devlink.c | 105 +++++++++++++++++++
>   drivers/net/ethernet/intel/ixd/ixd_devlink.h |  44 ++++++++
>   drivers/net/ethernet/intel/ixd/ixd_main.c    |  13 ++-
>   6 files changed, 196 insertions(+), 3 deletions(-)
>   create mode 100644 Documentation/networking/devlink/ixd.rst
>   create mode 100644 drivers/net/ethernet/intel/ixd/ixd_devlink.c
>   create mode 100644 drivers/net/ethernet/intel/ixd/ixd_devlink.h
>
> diff --git a/Documentation/networking/devlink/ixd.rst b/Documentation/networking/devlink/ixd.rst
> new file mode 100644
> index 000000000000..81b28ffb00f6
> --- /dev/null
> +++ b/Documentation/networking/devlink/ixd.rst

The index needs to be updated as well:

Documentation/networking/devlink/ixd.rst: WARNING: document isn't 
included in any toctree

Thanks,
Tony

> @@ -0,0 +1,35 @@
> +.. SPDX-License-Identifier: GPL-2.0
> +
> +===================
> +ixd devlink support
> +===================
> +
> +This document describes the devlink features implemented by the ``ixd``
> +device driver.
> +
> +Info versions