Re: [PATCH 02/11] vt: move unicode processing to a separate file

From: Nicolas Pitre
Date: Tue Apr 15 2025 - 15:03:53 EST


On Mon, 14 Apr 2025, Jiri Slaby wrote:

> On 10. 04. 25, 3:13, Nicolas Pitre wrote:
> > From: Nicolas Pitre <npitre@xxxxxxxxxxxx>
> >
> > This will make it easier to maintain. Also make it depend on
> > CONFIG_CONSOLE_TRANSLATIONS.
> ...
> > --- a/include/linux/consolemap.h
> > +++ b/include/linux/consolemap.h
> ...
> > @@ -57,6 +58,11 @@ static inline int conv_uni_to_8bit(u32 uni)
> > }
> >
> > static inline void console_map_init(void) { }
> > +
> > +static inline bool ucs_is_double_width(uint32_t cp)
> > +{
> > + return false;
> > +}
>
> Is this inline necessary? I assume ucs_is_double_width() won't be called
> outside CONFIG_CONSOLE_TRANSLATIONS?

It is, alongside the other functions in this header file.