Re: [PATCH] Bluetooth: vhci: Avoid needless snprintf() calls
From: patchwork-bot+bluetooth
Date: Tue Apr 15 2025 - 16:20:25 EST
Hello:
This patch was applied to bluetooth/bluetooth-next.git (master)
by Luiz Augusto von Dentz <luiz.von.dentz@xxxxxxxxx>:
On Tue, 15 Apr 2025 09:15:19 -0700 you wrote:
> Avoid double-copying of string literals. Use a "const char *" for each
> string instead of copying from .rodata into stack and then into the skb.
> We can go directly from .rodata to the skb.
>
> This also works around a Clang bug (that has since been fixed[1]).
>
> Reported-by: kernel test robot <lkp@xxxxxxxxx>
> Closes: https://lore.kernel.org/oe-kbuild-all/202401250927.1poZERd6-lkp@xxxxxxxxx/
> Fixes: ab4e4380d4e1 ("Bluetooth: Add vhci devcoredump support")
> Link: https://github.com/llvm/llvm-project/commit/ea2e66aa8b6e363b89df66dc44275a0d7ecd70ce [1]
> Cc: stable@xxxxxxxxxxxxxxx
> Signed-off-by: Kees Cook <kees@xxxxxxxxxx>
>
> [...]
Here is the summary with links:
- Bluetooth: vhci: Avoid needless snprintf() calls
https://git.kernel.org/bluetooth/bluetooth-next/c/3b32759328e9
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html