Re: [PATCH v2] rust: helpers: Remove volatile qualifier from io helpers

From: Miguel Ojeda
Date: Tue Apr 15 2025 - 17:13:31 EST


On Tue, Apr 15, 2025 at 9:14 PM Miguel Ojeda
<miguel.ojeda.sandonis@xxxxxxxxx> wrote:
>
> Applied to `rust-fixes` -- thanks everyone!
>
> [ Reworded for relative paths. - Miguel ]

Also:

[ Arnd explains [1] that removing the qualifier is the way forward
(thanks!):

Rihgt, I tried this last week when it came up first, removing the
'volatile' annotations in the asm-generic/io.h header and then
all the ones that caused build regressions on arm/arm64/x86
randconfig and allmodconfig builds. This patch is a little
longer than my original version as I did run into a few
regressions later.

As far as I can tell, none of these volatile annotations have
any actual effect, and most of them date back to ancient kernels
where this may have been required.

Leaving it out of the rust interface is clearly the right way,
and it shouldn't be too hard to upstream the changes below
when we need to, but I also don't see any priority to send these.
If anyone wants to help out, I can send them the whole patch.

I created an issue [2] in case someone wants to help. - Miguel ]

Cheers,
Miguel