Re: [RESEND PATCH] gpio: vf610: Allow building as a module

From: Linus Walleij
Date: Tue Apr 15 2025 - 17:46:24 EST


On Tue, Apr 8, 2025 at 5:15 PM Jindong Yue <jindong.yue@xxxxxxx> wrote:

> Support for building it as a module for use on the Android
> platform, because the Android kernel(GKI) doesn't contain
> board-specific drivers, it requires that these drivers
> be built as a module and loaded into the system.
>
> Signed-off-by: Jindong Yue <jindong.yue@xxxxxxx>
(...)

> builtin_platform_driver(vf610_gpio_driver);
> +MODULE_DESCRIPTION("VF610 GPIO driver");
> +MODULE_LICENSE("GPL");

You compile a builtin_platform_driver() and then claim this is
a module?

Switch the builtin_platform_driver() to module_platform_driver().

(Also make sure that removing the module actually works, please.)

Yours,
Linus Walleij