[PATCH 1/7] platform/chrome: cros_ec_typec: No pending status means attention
From: Stephen Boyd
Date: Tue Apr 15 2025 - 20:02:30 EST
If we aren't expecting a status update when
cros_typec_displayport_status_update() is called then we're handling an
attention message, like HPD high/low or IRQ. Call
typec_altmode_attention() in this case so that HPD signaling works in
the DP altmode driver.
Cc: Benson Leung <bleung@xxxxxxxxxxxx>
Cc: Tzung-Bi Shih <tzungbi@xxxxxxxxxx>
Cc: <chrome-platform@xxxxxxxxxxxxxxx>
Cc: Pin-yen Lin <treapking@xxxxxxxxxxxx>
Cc: Abhishek Pandit-Subedi <abhishekpandit@xxxxxxxxxxxx>
Cc: Łukasz Bartosik <ukaszb@xxxxxxxxxxxx>
Cc: Jameson Thies <jthies@xxxxxxxxxx>
Cc: Andrei Kuchynski <akuchynski@xxxxxxxxxxxx>
Signed-off-by: Stephen Boyd <swboyd@xxxxxxxxxxxx>
---
drivers/platform/chrome/cros_typec_altmode.c | 7 ++-----
1 file changed, 2 insertions(+), 5 deletions(-)
diff --git a/drivers/platform/chrome/cros_typec_altmode.c b/drivers/platform/chrome/cros_typec_altmode.c
index 557340b53af0..c2d9c548b5e8 100644
--- a/drivers/platform/chrome/cros_typec_altmode.c
+++ b/drivers/platform/chrome/cros_typec_altmode.c
@@ -280,11 +280,8 @@ int cros_typec_displayport_status_update(struct typec_altmode *altmode,
typec_altmode_get_drvdata(altmode);
struct cros_typec_altmode_data *adata = &dp_data->adata;
- if (!dp_data->pending_status_update) {
- dev_dbg(&altmode->dev,
- "Got DPStatus without a pending request\n");
- return 0;
- }
+ if (!dp_data->pending_status_update)
+ return typec_altmode_attention(altmode, data->status);
if (dp_data->configured && dp_data->data.conf != data->conf)
dev_dbg(&altmode->dev,
--
https://chromeos.dev