Re: [PATCH] MIPS: Remove unnecessary zero-length struct member

From: Maciej W. Rozycki
Date: Tue Apr 15 2025 - 22:33:42 EST


On Fri, 11 Apr 2025, Thorsten Blum wrote:

> Remove the zero-length struct member '__last' and use sizeof() to
> calculate the value for MAX_REG_OFFSET.
>
> No functional changes intended.

Have you verified that there's no change except for timestamp data in
(non-debug) `vmlinux' produced with and w/o the patch applied?

Also this is broken anyway: if you use MAX_REG_OFFSET for `offset' passed
to `regs_get_register', then data past the end of `regs' will be accessed.

Maciej