Re: [PATCH] gpio: nomadik: Add check for clk_enable()

From: Linus Walleij
Date: Wed Apr 16 2025 - 04:35:29 EST


On Mon, Apr 14, 2025 at 2:11 PM Chenyuan Yang <chenyuan0y@xxxxxxxxx> wrote:
> On Mon, Apr 14, 2025 at 4:24 AM Théo Lebrun <theo.lebrun@xxxxxxxxxxx> wrote:

> > Seeing the __irq_startup() code, my proposal would be to turn the return
> > value to a signed int, but I haven't exhaustively checked codepaths.
>
> Good catch! I agree that using a signed int could be a better option.
>
> Dear Linus and Bartosz, could you please share your thoughts? If
> you’re on board with the change, I’ll go ahead and send a new patch.

Yeah that would be great, thanks!

Thanks for noticing this as well Theo, I think your team is the
most important user of this code right now.

Yours,
Linus Walleij