Re: [PATCH 1/4] crypto: img-hash - use API helpers to setup fallback request

From: Corentin Labbe
Date: Wed Apr 16 2025 - 05:57:25 EST


Le Wed, Apr 16, 2025 at 03:55:39PM +0800, Herbert Xu a écrit :
> On Mon, Apr 07, 2025 at 03:36:01PM +0300, Ovidiu Panait wrote:
> > Rather than setting up the fallback request by hand, use
> > ahash_request_set_callback() and ahash_request_set_crypt() API helpers
> > to properly setup the new request.
> >
> > This also ensures that the completion callback is properly passed down
> > to the fallback algorithm, which avoids a crash with async fallbacks.
> >
> > Signed-off-by: Ovidiu Panait <ovidiu.panait.oss@xxxxxxxxx>
> > ---
> > drivers/crypto/img-hash.c | 41 ++++++++++++++++++++++-----------------
> > 1 file changed, 23 insertions(+), 18 deletions(-)
>
> Patches 1-2,4 applied. Thanks.

You can merge sun8i-ss patch, it is ok.

Could you add my tested-by on rk3328 patch also ?

Thanks