Re: [PATCH v2 04/13] vt: introduce gen_ucs_width_table.py to create ucs_width_table.h

[Nicolas Pitre]

On Wed, 16 Apr 2025, Jiri Slaby wrote:

> On 16. 04. 25, 6:14, Jiri Slaby wrote:
> > On 15. 04. 25, 21:17, Nicolas Pitre wrote:
> >> From: Nicolas Pitre <npitre@xxxxxxxxxxxx>
> >>
> >> The table in ucs.c is terribly out of date and incomplete. We also need a
> >> second table to store zero-width code points. Properly maintaining those
> >> tables manually is impossible. So here's a script to generate them.
> >>
> >> Signed-off-by: Nicolas Pitre <npitre@xxxxxxxxxxxx>
> > 
> > Reviewed-by: Jiri Slaby <jirislaby@xxxxxxxxxx>
> 
> Actually, could you create a makefile rule for this too?
> 
> Similar to what GENERATE_KEYMAP does in vt/Makefile.
> 
> So that you would do:
>   make GENERATE_UCS_WIDTH_TABLE=1 drivers/tty/vt/
> to let the script generate it on the fly?

Sure. I have more patches coming up so I'll bundle that change with 
them.


Nicolas