Re: [PATCH v4] fs/fs_parse: Remove unused and problematic validate_constant_table()

From: Christian Brauner
Date: Wed Apr 16 2025 - 10:10:33 EST


On Tue, 15 Apr 2025 20:25:00 +0800, Zijun Hu wrote:
> Remove validate_constant_table() since:
>
> - It has no caller.
>
> - It has below 3 bugs for good constant table array array[] which must
> end with a empty entry, and take below invocation for explaination:
> validate_constant_table(array, ARRAY_SIZE(array), ...)
>
> [...]

Applied to the vfs-6.16.misc branch of the vfs/vfs.git tree.
Patches in the vfs-6.16.misc branch should appear in linux-next soon.

Please report any outstanding bugs that were missed during review in a
new review to the original patch series allowing us to drop it.

It's encouraged to provide Acked-bys and Reviewed-bys even though the
patch has now been applied. If possible patch trailers will be updated.

Note that commit hashes shown below are subject to change due to rebase,
trailer updates or similar. If in doubt, please check the listed branch.

tree: https://git.kernel.org/pub/scm/linux/kernel/git/vfs/vfs.git
branch: vfs-6.16.misc

[1/1] fs/fs_parse: Remove unused and problematic validate_constant_table()
https://git.kernel.org/vfs/vfs/c/02c827b74082