Re: [PATCH v2] dmaengine: ptdma: Remove unused pointer dma_cmd_cache

From: Nathan Lynch
Date: Wed Apr 16 2025 - 10:56:52 EST


Eder Zulian <ezulian@xxxxxxxxxx> writes:
> The pointer 'struct kmem_cache *dma_cmd_cache' was introduced in commit
> 'b0b4a6b10577 ("dmaengine: ptdma: register PTDMA controller as a DMA
> resource")' but it was never used.
>
> Changes since v1:
> - Remove the 'err_cache' label and return -ENOMEM directly instead of
> assigning -ENOMEM to 'ret' and jumping to the label, since there
> are no unmanaged allocations to unwind. Based on suggestion from
> Nathan Lynch.
> - Fix checkpatch.pl error: ERROR: Please use git commit description style
> 'commit <12+ chars of sha1> ("<title line>")'
>
> Signed-off-by: Eder Zulian <ezulian@xxxxxxxxxx>

Reviewed-by: Nathan Lynch <nathan.lynch@xxxxxxx>