Re: [PATCH] clk: qcom: Fix missing error check for dev_pm_domain_attach()
From: Bjorn Andersson
Date: Wed Apr 16 2025 - 14:12:11 EST
On Tue, 11 Feb 2025 17:20:17 +0800, Wentao Liang wrote:
> In the current implementation, the return value of dev_pm_domain_attach()
> is not checked. This can lead to silent failures if the function fails,
> as the code would continue execution and return 0, ignoring the error.
>
> This patch adds a check for the return value of dev_pm_domain_attach().
> If the function fails, an error message is logged using dev_err_probe(),
> and the error is propagated to the existing error handling path `err`,
> which ensures proper cleanup by calling clk_notifier_unregister().
>
> [...]
Applied, thanks!
[1/1] clk: qcom: Fix missing error check for dev_pm_domain_attach()
commit: 36eb51ac8bd545b6344c05a9860e4e65ba8d7a62
Best regards,
--
Bjorn Andersson <andersson@xxxxxxxxxx>