Re: [PATCH] x86/Kconfig: make CFI_AUTO_DEFAULT depend on !RUST
From: Peter Zijlstra
Date: Wed Apr 16 2025 - 16:20:59 EST
On Tue, Apr 15, 2025 at 05:15:31PM +0200, Miguel Ojeda wrote:
> On Thu, Apr 10, 2025 at 4:00 PM Alice Ryhl <aliceryhl@xxxxxxxxxx> wrote:
> >
> > I submitted a PR that I believe should fix it:
> > https://github.com/rust-lang/rust/pull/139632
>
> This landed, scheduled for Rust 1.88 (2025-06-26) if all goes well.
>
> Peter: are you OK with landing a patch like this? Well, modified to
> look like this now that we know the version:
>
> depends on FINEIBT
> depends on !RUST || RUSTC_VERSION >= 108800
>
> (assuming we confirm the nightly build works properly)
I don't much like it -- disabling FineIBT at config time like this also
kills the CFI type rehash. Not to mention that FineIBT is a Spectre-BHI
mitigation, esp. with that arity thing on top.
I don't suppose we can simply mandate this rust version?
Speaking of which, I should go install this latest rust thing....