Re: [PATCH v3 03/10] gpio: aggregator: move GPIO forwarder allocation in a dedicated function

From: Andy Shevchenko
Date: Thu Apr 17 2025 - 12:56:53 EST


On Wed, Apr 16, 2025 at 04:08:11PM +0200, Thomas Richard wrote:
> Move the GPIO forwarder allocation and static initialization in a dedicated
> function.

Reviewed-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>

...

> + fwd = devm_kzalloc(dev, struct_size(fwd, tmp, fwd_tmp_size(ngpios)),
> + GFP_KERNEL);

You can keep it one line.

> + if (!fwd)
> + return ERR_PTR(-ENOMEM);


--
With Best Regards,
Andy Shevchenko