Re: [PATCH 2/8] iio: adc: mt6360-adc: use aligned_s64 for timestamp

From: Jonathan Cameron
Date: Fri Apr 18 2025 - 10:45:22 EST


On Fri, 18 Apr 2025 09:57:09 +0100
Nuno Sá <noname.nuno@xxxxxxxxx> wrote:

> On Thu, 2025-04-17 at 11:52 -0500, David Lechner wrote:
> > Follow the pattern of other drivers and use aligned_s64 for the
> > timestamp. This will ensure that the timestamp is correctly aligned on
> > all architectures. It also ensures that the struct itself it also 8-byte
> > aligned so we can drop the explicit __aligned(8) attribute.
> >
> > Signed-off-by: David Lechner <dlechner@xxxxxxxxxxxx>
> > ---
>
> Reviewed-by: Nuno Sá <nuno.sa@xxxxxxxxxx>
Applied.
>
> >  drivers/iio/adc/mt6360-adc.c | 4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/iio/adc/mt6360-adc.c b/drivers/iio/adc/mt6360-adc.c
> > index
> > 4eb2455d6ffacb8f09a404df4490b5a11e49660d..f8e98b6fa7e923c6b73bedf9ca1c466e7a9c3c47
> > 100644
> > --- a/drivers/iio/adc/mt6360-adc.c
> > +++ b/drivers/iio/adc/mt6360-adc.c
> > @@ -263,8 +263,8 @@ static irqreturn_t mt6360_adc_trigger_handler(int irq, void *p)
> >   struct mt6360_adc_data *mad = iio_priv(indio_dev);
> >   struct {
> >   u16 values[MT6360_CHAN_MAX];
> > - int64_t timestamp;
> > - } data __aligned(8);
> > + aligned_s64 timestamp;
> > + } data;
> >   int i = 0, bit, val, ret;
> >  
> >   memset(&data, 0, sizeof(data));
> >
>