Re: [PATCH v6 02/12] mfd: Add max7360 support

[Mathieu Dubois-Briand]

On Thu Apr 17, 2025 at 8:16 PM CEST, Andy Shevchenko wrote:
> On Wed, Apr 09, 2025 at 04:55:49PM +0200, mathieu.dubois-briand@xxxxxxxxxxx wrote:
>> From: Kamel Bouhara <kamel.bouhara@xxxxxxxxxxx>
>> 
>> Add core driver to support MAX7360 i2c chip, multi function device
>> with keypad, GPIO, PWM, GPO and rotary encoder submodules.
>
> ...
>
>> +static int max7360_probe(struct i2c_client *client)
>> +{
>> +	struct device *dev = &client->dev;
>> +	struct regmap *regmap;
>> +	int ret;
>> +
>> +	regmap = devm_regmap_init_i2c(client, &max7360_regmap_config);
>> +	if (IS_ERR(regmap))
>> +		return dev_err_probe(dev, PTR_ERR(regmap), "Failed to initialise regmap\n");
>
>> +	i2c_set_clientdata(client, regmap);
>
> Is it used somehow? In children?
>

I cannot see where it would be used in the code, and removing it has no
effect. I will remove it.

Thanks for your review.
Mathieu

-- 
Mathieu Dubois-Briand, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com