Re: [PATCH v3 05/32] selftests: harness: Remove inline qualifier for wrappers

[Muhammad Usama Anjum]

On 4/11/25 2:00 PM, Thomas Weißschuh wrote:
> The pointers to the wrappers are stored in function pointers,
> preventing them from actually being inlined.
> Remove the inline qualifier, aligning these wrappers with the other
> functions defined through macros.
> 
> Signed-off-by: Thomas Weißschuh <thomas.weissschuh@xxxxxxxxxxxxx>
Reviewed-by: Muhammad Usama Anjum <usama.anjum@xxxxxxxxxxxxx>

> ---
>  tools/testing/selftests/kselftest_harness.h | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/tools/testing/selftests/kselftest_harness.h b/tools/testing/selftests/kselftest_harness.h
> index 5822bc0b86a3c623fd34830fb8b541b27672a00b..222a4f51a8d704c41597e09a241ad887ef787139 100644
> --- a/tools/testing/selftests/kselftest_harness.h
> +++ b/tools/testing/selftests/kselftest_harness.h
> @@ -172,7 +172,7 @@
>  
>  #define __TEST_IMPL(test_name, _signal) \
>  	static void test_name(struct __test_metadata *_metadata); \
> -	static inline void wrapper_##test_name( \
> +	static void wrapper_##test_name( \
>  		struct __test_metadata *_metadata, \
>  		struct __fixture_variant_metadata __attribute__((unused)) *variant) \
>  	{ \
> @@ -401,7 +401,7 @@
>  		struct __test_metadata *_metadata, \
>  		FIXTURE_DATA(fixture_name) *self, \
>  		const FIXTURE_VARIANT(fixture_name) *variant); \
> -	static inline void wrapper_##fixture_name##_##test_name( \
> +	static void wrapper_##fixture_name##_##test_name( \
>  		struct __test_metadata *_metadata, \
>  		struct __fixture_variant_metadata *variant) \
>  	{ \
> 


-- 
Regards,
Usama