Re: [PATCH] HID: intel-thc-hid: intel-quicki2c: pass correct arguments to acpi_evaluate_object

[Jiri Kosina]

On Thu, 17 Apr 2025, WangYuli wrote:

> From: Wentao Guan <guanwentao@xxxxxxxxxxxxx>
> 
> Delete unused argument, pass correct argument to acpi_evaluate_object.
> 
> Log:
>   intel_quicki2c 0000:00:10.0: enabling device (0000 -> 0002)
>   ACPI: \_SB.PC00.THC0.ICRS: 1 arguments were passed to a non-method ACPI object (Buffer) (20230628/nsarguments-211)
>   ACPI: \_SB.PC00.THC0.ISUB: 1 arguments were passed to a non-method ACPI object (Buffer) (20230628/nsarguments-211)
> 
> Fixes: 5282e45ccbfa ("HID: intel-thc-hid: intel-quicki2c: Add THC QuickI2C ACPI interfaces")
> Signed-off-by: Wentao Guan <guanwentao@xxxxxxxxxxxxx>
> Signed-off-by: WangYuli <wangyuli@xxxxxxxxxxxxx>
> ---
>  drivers/hid/intel-thc-hid/intel-quicki2c/pci-quicki2c.c | 7 +------
>  1 file changed, 1 insertion(+), 6 deletions(-)
> 
> diff --git a/drivers/hid/intel-thc-hid/intel-quicki2c/pci-quicki2c.c b/drivers/hid/intel-thc-hid/intel-quicki2c/pci-quicki2c.c
> index fa51155ebe39..8a8c4a46f927 100644
> --- a/drivers/hid/intel-thc-hid/intel-quicki2c/pci-quicki2c.c
> +++ b/drivers/hid/intel-thc-hid/intel-quicki2c/pci-quicki2c.c
> @@ -82,15 +82,10 @@ static int quicki2c_acpi_get_dsd_property(struct acpi_device *adev, acpi_string
>  {
>  	acpi_handle handle = acpi_device_handle(adev);
>  	struct acpi_buffer buffer = { ACPI_ALLOCATE_BUFFER, NULL };
> -	union acpi_object obj = { .type = type };
> -	struct acpi_object_list arg_list = {
> -		.count = 1,
> -		.pointer = &obj,
> -	};
>  	union acpi_object *ret_obj;
>  	acpi_status status;
>  
> -	status = acpi_evaluate_object(handle, dsd_method_name, &arg_list, &buffer);
> +	status = acpi_evaluate_object(handle, dsd_method_name, NULL, &buffer);
>  	if (ACPI_FAILURE(status)) {
>  		acpi_handle_err(handle,
>  				"Can't evaluate %s method: %d\n", dsd_method_name, status);

Applied, thanks.

-- 
Jiri Kosina
SUSE Labs