Re: [PATCH v3] arm64: dts: qcom: add initial support for qcom sa8255p-ride

[Krzysztof Kozlowski]

On 25/04/2025 06:53, Deepti Jaggi wrote:
> 
> 
> On 4/23/25 23:19, Krzysztof Kozlowski wrote:
>> On 23/04/2025 01:12, Deepti Jaggi wrote:
>>> diff --git a/arch/arm64/boot/dts/qcom/sa8255p-ride.dts b/arch/arm64/boot/dts/qcom/sa8255p-ride.dts
>>> new file mode 100644
>>> index 000000000000..cb866f897d0a
>>> --- /dev/null
>>> +++ b/arch/arm64/boot/dts/qcom/sa8255p-ride.dts
>>> @@ -0,0 +1,94 @@
>>> +// SPDX-License-Identifier: BSD-3-Clause
>>> +/*
>>> + * Copyright (c) 2024-2025 Qualcomm Innovation Center, Inc. All rights reserved.
>>> + */
>>> +
>>> +/dts-v1/;
>>> +
>>> +#include <dt-bindings/gpio/gpio.h>
>>> +
>>> +#include "sa8255p.dtsi"
>>> +#include "sa8255p-pmics.dtsi"
>>> +#include "sa8255p-scmi.dtsi"
>>> +
>>> +/ {
>>> +	model = "Qualcomm Technologies, Inc. SA8255P Ride";
>>> +	compatible = "qcom,sa8255p-ride", "qcom,sa8255p";
>>
>> NAK
>>
>> Missing bindings. This is some weird process you have there. Reach to
>> your internal guideline before you start posting. It explains this.
>>
> 
> I followed the approach used for other bindings [1] [2] [3], 
> which were part of the original series and were sent as separate patches 
> and accepted. I misjudged that the SoC binding could also be sent as a 
> separate patch. I will combine the remaining bindings along with 
> the device tree into a single series.
>  
> The UART/QUP driver changes have been posted as a separate series [4] 
> along with the UART bindings. Please advise if the UART/QUP bindings should
> also be included as part of next series with dt changes.

I think existing docs have it well covered and explained. I advise to
read all submitting patches documents.


Best regards,
Krzysztof