Re: [PATCH v6 02/11] dt-bindings: iio: adc: ad7768-1: add trigger-sources property

From: David Lechner
Date: Wed Apr 30 2025 - 14:46:57 EST


On 4/27/25 7:12 PM, Jonathan Santos wrote:
> In addition to GPIO synchronization, The AD7768-1 also supports
> synchronization over SPI, which use is recommended when the GPIO
> cannot provide a pulse synchronous with the base MCLK signal. It
> consists of looping back the SYNC_OUT to the SYNC_IN pin and send
> a command via SPI to trigger the synchronization.
>
> Introduce the 'trigger-sources' property to enable SPI-based
> synchronization via SYNC_OUT pin, along with additional optional
> entries for GPIO3 and DRDY pins.
>
> Also create #trigger-source-cells property to differentiate the trigger
> sources provided by the ADC. To improve readability, create a
> adi,ad7768-1.h header with the macros for the cell values.
>
> While at it, add description to the interrupts property.
>
> Signed-off-by: Jonathan Santos <Jonathan.Santos@xxxxxxxxxx>
> ---


...

> ---
> .../bindings/iio/adc/adi,ad7768-1.yaml | 31 ++++++++++++++++++-
> include/dt-bindings/iio/adc/adi,ad7768-1.h | 10 ++++++
> 2 files changed, 40 insertions(+), 1 deletion(-)
> create mode 100644 include/dt-bindings/iio/adc/adi,ad7768-1.h

We should add this new file to the MAINTAINERS entry.

Otherwise:

Reviewed-by: David Lechner <dlechner@xxxxxxxxxxxx>