Re: [PATCH v1] rust: time: Avoid 64-bit integer division

From: Boqun Feng
Date: Thu May 01 2025 - 09:25:23 EST


On Thu, May 01, 2025 at 03:22:00PM +0200, Miguel Ojeda wrote:
> On Thu, May 1, 2025 at 3:12 PM Boqun Feng <boqun.feng@xxxxxxxxx> wrote:
> >
> > #[cfg(CONFIG_ARM)]
> > fn ns_to_ms(ns: i64) -> i64 {
> >
> > #[cfg(not(CONFIG_ARM))]
> > fn ns_to_ms(ns: i64) -> i64 {
>
> I think `cfg`s may be better inside, i.e. as local as reasonably
> possible, so that we share e.g. signature as well as any attributes
> and docs.
>

Fair enough.

Regards,
Boqun

> Cheers,
> Miguel
>