Re: [PATCH v5 3/7] x86/fpu/xstate: Differentiate default features for host and guest FPUs

From: Chang S. Bae
Date: Thu May 01 2025 - 10:24:54 EST


On 4/10/2025 12:24 AM, Chao Gao wrote:

+struct vcpu_fpu_config guest_default_cfg __ro_after_init;

I just noticed that the patch set is missing the initialization of guest_default_cfg.size = size (or legacy_size) in the following functions:

fpu__init_system_xstate_size_legacy()
fpu__init_disable_system_xstate()

Without that, it looks buggy when XSAVE is either unavailable or disabled.

Thanks,
Chang