Re: [PATCH v9 13/27] x86/resctrl: Move enum resctrl_event_id to resctrl.h

[Reinette Chatre]

Hi James,

On 4/25/25 10:37 AM, James Morse wrote:
> A previous patch moved enum resctrl_event_id into a smaller header file,

We have had trouble using "previous patch" and "next patch" in changelogs
because of how patches may be re-organized after merge and backports and such.

Considering this I'd propose something like (please feel free to improve):

  resctrl_types.h contains common types and constants to enable architectures
  to use these types in their definitions within asm/resctrl.h.
  
  enum resctrl_event_id was placed in resctrl_types.h for
  resctrl_arch_get_cdp_enabled() and resctrl_arch_set_cdp_enabled(), but
  these two functions are no longer inlined by any architecture.

  Move enum resctrl_event_id to resctrl.h.

> resctrl_types.h, so that architectures could use these types in their
> definitions of asm/resctrl.h. Specifically this was for
> resctrl_arch_get_cdp_enabled() and resctrl_arch_set_cdp_enabled().
> 
> Those two functions are no longer inlined by any architecture, so
> the enum can be moved to resctrl.h.
> 
> Signed-off-by: James Morse <james.morse@xxxxxxx>
> ---

With "previous patch" addressed:
| Reviewed-by: Reinette Chatre <reinette.chatre@xxxxxxxxx>

Thank you.

Reinette