Re: [PATCH v2 2/2] Documentation: wmi: alienware-wmi: Add GPIO control documentation

[Armin Wolf]

Am 27.04.25 um 08:24 schrieb Kurt Borja via B4 Relay:

> From: Kurt Borja <kuurtb@xxxxxxxxx>
>
> Add documentation for the GPIO control methods.
>
> Signed-off-by: Kurt Borja <kuurtb@xxxxxxxxx>
> ---
>   Documentation/wmi/devices/alienware-wmi.rst | 78 +++++++++++++++++++++++++++--
>   1 file changed, 74 insertions(+), 4 deletions(-)
>
> diff --git a/Documentation/wmi/devices/alienware-wmi.rst b/Documentation/wmi/devices/alienware-wmi.rst
> index 79238051b18bc5de9b502325017cd5c5fcf41748..2a6052efb9ae0e3fe0a5d9d5775073234dfc96fb 100644
> --- a/Documentation/wmi/devices/alienware-wmi.rst
> +++ b/Documentation/wmi/devices/alienware-wmi.rst
> @@ -231,6 +231,70 @@ WMI method MemoryOCControl([in] uint32 arg2, [out] uint32 argr)
>   AWCC supports memory overclocking, but this method is very intricate and has
>   not been deciphered yet.
>   
> +GPIO control Methods
> +====================
> +
> +Alienware and Dell G Series devices with the AWCC interface usually have an
> +embedded STM32 RGB lighting controller with USB/HID capabilities. It's vendor ID
> +is ``187c`` while it's product ID may vary from model to model.
> +
> +The control of two GPIO pins of this MCU is exposed as WMI methods for debugging
> +purposes.
> +
> ++--------------+--------------------------------------------------------------+
> +| Pin          | Description                                                  |
> ++==============+===============================+==============================+
> +| 0            | Device Firmware Update (DFU)  | **HIGH**: Enables DFU mode   |
> +|              | mode pin.                     | on next MCU boot.            |
> +|              |                               +------------------------------+
> +|              |                               | **LOW**: Disables DFU mode   |
> +|              |                               | on next MCU boot.            |
> ++--------------+-------------------------------+------------------------------+
> +| 1            | Negative Reset (NRST) pin.    | **HIGH**: MCU is ON.         |
> +|              |                               |                              |
> +|              |                               +------------------------------+
> +|              |                               | **LOW**: MCU is OFF.         |
> +|              |                               |                              |
> ++--------------+-------------------------------+------------------------------+
> +
> +See :ref:`acknowledgements` for more information on this MCU.
> +
> +.. note::
> +   Some GPIO control methods break the usual argument structure and take a
> +   **Pin number** instead of an operation on the first byte.
> +
> +WMI method FWUpdateGPIOtoggle([in] uint32 arg2, [out] uint32 argr)
> +------------------------------------------------------------------
> +
> ++--------------------+------------------------------------+--------------------+
> +| Operation (Byte 0) | Description                        | Arguments          |
> ++====================+====================================+====================+
> +| Pin number         | Set the pin status                 | - Byte 1: Pin      |
> +|                    |                                    |   status           |
> ++--------------------+------------------------------------+--------------------+
> +
> +WMI method ReadTotalofGPIOs([out] uint32 argr)
> +----------------------------------------------
> +
> ++--------------------+------------------------------------+--------------------+
> +| Operation (Byte 0) | Description                        | Arguments          |
> ++====================+====================================+====================+
> +| 0x00               | Get the total number of GPIOs      | - None             |
> ++--------------------+------------------------------------+--------------------+

Maybe you should write that the "Operation" byte is theoretically not necessary for this WMI method,
but that we still have to provide a dummy value or else the firmware will encounter an error.

Take a look at the documentation for the msi-wmi-platform driver for details (grep for "CreateByteField()").

Other than that:

Reviewed-by: Armin Wolf <W_Armin@xxxxxx>

> +
> +WMI method ReadGPIOpPinStatus([in] uint32 arg2, [out] uint32 argr)
> +------------------------------------------------------------------
> +
> ++--------------------+------------------------------------+--------------------+
> +| Operation (Byte 0) | Description                        | Arguments          |
> ++====================+====================================+====================+
> +| Pin number         | Get the pin status                 | - None             |
> ++--------------------+------------------------------------+--------------------+
> +
> +.. note::
> +   There known firmware bug in some laptops where reading the status of a pin
> +   also flips it.
> +
>   Other information Methods
>   =========================
>   
> @@ -239,10 +303,16 @@ WMI method ReadChassisColor([out] uint32 argr)
>   
>   Returns the chassis color internal ID.
>   
> +.. _acknowledgements:
> +
>   Acknowledgements
>   ================
>   
> -Kudos to `AlexIII <https://github.com/AlexIII/tcc-g15>`_ and
> -`T-Troll <https://github.com/T-Troll/alienfx-tools/>`_ for documenting and
> -testing some of this device's functionality, making it possible to generalize
> -this driver.
> +Kudos to
> +
> +* `AlexIII <https://github.com/AlexIII/tcc-g15>`_
> +* `T-Troll <https://github.com/T-Troll/alienfx-tools/>`_
> +* `Gabriel Marcano <https://gabriel.marcanobrady.family/blog/2024/12/16/dell-g5-5505-se-acpi-or-figuring-out-how-to-reset-the-rgb-controller/>`_
> +
> +for documenting and testing some of this device's functionality, making it
> +possible to generalize this driver.