Re: [PATCH v4 02/15] x86/msr: Move rdtsc{,_ordered}() to <asm/tsc.h>
From: Ingo Molnar
Date: Fri May 02 2025 - 04:53:10 EST
* Xin Li (Intel) <xin@xxxxxxxxx> wrote:
> For some reason, there are some TSC-related functions in the MSR
> header even though there is a tsc.h header.
>
> Relocate rdtsc{,_ordered}() from <asm/msr.h> to <asm/tsc.h>, and
> subsequently remove the inclusion of <asm/msr.h> in <asm/tsc.h>.
>
> Signed-off-by: Xin Li (Intel) <xin@xxxxxxxxx>
> Acked-by: Dave Hansen <dave.hansen@xxxxxxxxxxxxxxx>
> Acked-by: Peter Zijlstra (Intel) <peterz@xxxxxxxxxxxxx>
> --- a/arch/x86/include/asm/tsc.h
> +++ b/arch/x86/include/asm/tsc.h
> @@ -7,7 +7,81 @@
>
> #include <asm/cpufeature.h>
> #include <asm/processor.h>
> -#include <asm/msr.h>
Note that in the tip:x86/msr commit I've applied today I've
intentionally delayed the removal of this header dependency, to reduce
the probability of breaking -next today or in the near future.
We can remove that now superfluous header dependency in a future patch.
Thanks,
Ingo