Re: [PATCH] bpftool: build bpf bits with -std=gnu11

[Holger Hoffstätte]

On 2025-05-02 11:26, Quentin Monnet wrote:
> On 02/05/2025 09:57, Holger Hoffstätte wrote:
> > A gcc-15-based bpf toolchain defaults to C23 and fails to compile various
> > kernel headers due to their use of a custom 'bool' type.
> > Explicitly using -std=gnu11 works with both clang and bpf-toolchain.
> >
> > Signed-off-by: Holger Hoffstätte <holger@xxxxxxxxxxxxxxxxxxxxxx>
>
> Thanks! I tested that it still works with clang.
>
> Acked-by: Quentin Monnet <qmo@xxxxxxxxxx>

Thanks!

> I didn't manage to compile with gcc, though. I tried with gcc 15.1.1 but
> option '--target=bpf' is apparently unrecognised by the gcc version on
> my setup.
>
> Out of curiosity, how did you build using gcc for the skeleton? Was it
> enough to run "CLANG=gcc make"? Does it pass the clang-bpf-co-re build
> probe successfully?

I'm on Gentoo where we have a gcc-14/15 based "bpf-toolchain" package,
which is just gcc configured & packaged for the bpf target.
Our bpftool package can be built with clang (default) or without, in
which case it depend on the bpf-toolchain. The idea is to gradually
allow bpf/xdp tooling to build/run without requiring clang.

The --target definition is conditional and removed when not using clang:
https://gitweb.gentoo.org/repo/gentoo.git/tree/dev-util/bpftool/bpftool-7.5.0.ebuild?id=bf70fbf7b0dc97fbc97af579954ea81a8df36113#n94

The bug for building with the new gcc-15 based toolchain where this
patch originated is here: https://bugs.gentoo.org/955156

Hope this helps!

cheers
Holger