Re: [PATCH 1/4] selftests/mm/uffd: Refactor non-composite global vars into struct

From: Brendan Jackman
Date: Fri May 02 2025 - 08:28:33 EST


On Fri, 2 May 2025 at 14:16, Brendan Jackman <jackmanb@xxxxxxxxxx> wrote:
> Little bit of indentation mess here
>
> I don't understand this code but since I was hurt by these global
> variables I had a look over the diff anyway, it LGTM (aside from the
> formatting nits), thanks.
>
> Reviewed-by: Brendan Jackman <jackmanb@xxxxxxxxxx>

Wait sorry, actually, this deletes the global vars before it deletes
the references to them. That's gonna be a real pain for bisections,
please can you restructure the series to prevent intervening build
failures?

(I.e. if I apply just 1/4, the selftests don't compile).